-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for building andromeda testnet on local #99
Conversation
Clever. I figured we'd have it use a local build of pyth/op-gas packages and create a new top-level cannonfile, but I like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to swap the staleness circuit breaker node?
Is it possible to use a mock contract for the we cannot use in non-forked networks instead of changing the nodes architecture? That way the change is minimized (and more accurate to what is expected to happen in real networks) for local tests. There's already a PR to introduce a mock for prebuilt ovm contract used here: Synthetixio/synthetix-v3#1963 |
0d16285
to
5c05fe4
Compare
5c05fe4
to
ee2a88c
Compare
accomplishes this by detecting the chain id of the currently building network. if its local, it replaces problematic oracle nodes with constant nodes otherwise, the deployed network extremely closely resembles what is actually deployed to testnet, even after upgrades. this would be suitable for building a non-fork sandbox of any network (although right now its only tested with andromeda testnet)
ee2a88c
to
d51127c
Compare
yes we can use a mock oracle instead just as easily. do oyu think you could get your PR merged upstream so we can implement it here more reliably? |
accomplishes this by detecting the chain id of the currently building network. if its local, it replaces problematic oracle nodes with constant nodes
otherwise, the deployed network extremely closely resembles what is actually deployed to testnet, even after upgrades. this would be suitable for building a non-fork sandbox of any network (although right now its only tested with andromeda testnet)